Design comparison
Solution retrospective
I think I got the sizing done much better using measuring tools online.
What challenges did you encounter, and how did you overcome them?Centering all items within the card and getting special spacing between some elements but not others. I was able to do this by using flexbox for the card element but applying data attributes to elements that had unique aspects.
I also used custom properties to set up reusable variables.
What specific areas of your project would you like help with?Be critical! What's a better way I could do something? What did I miss?
Community feedback
- @sunnyeggPosted 6 days ago
Hi! First of all, good job on completing the challenge! There are some things that I noticed when I looked at your site and the code.
-
The website is fine when I open it on Desktop Screen, but when I downsize the screen to Mobile, the card got really tiny. I think you can just remove the
width
and theheight
on yourcard
class. Or you can set the maximum of the card's size usingmax-width
andmax-height
attributes. -
Remove unused codes in your CSS file.
Cheers!
Marked as helpful1@devindubinPosted 6 days agoThank you for commenting! @sunnyegg
I just pushed an update that fixed the mobile presentation, there was a bug in my css media query.
0 -
- @dbachour86Posted 6 days ago
Nice work, but isn't it better to use
h2
,h3
, andul
tags? You are using a lot ofp
tags.1@devindubinPosted 6 days agoThank you for commenting! @dbachour86
I chose not to use other header tags because apart from the user name the sizes looked fairly similar to me and didn't require such a distinction. Apart from default sizing, I am unfamiliar with the benefits of using header tags (apart from a single h1) as opposed to setting classes. Maybe I could have saved some code when setting font-weights that way? I hadn't considered it so thank you for the tip!
As for the links, I chose not to nest them in a ul tag because they appeared similar enough to the other text (which was also centered) to keep them in the same container as everything else rather than have li elements inside a ul element. Next challenge I will try your method and see if I notice any major differences.
Thank you!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord