
Design comparison
Solution retrospective
I think I have a prettier code than on the last project where I used divs for everything.
What challenges did you encounter, and how did you overcome them?Getting started is always the most challenging to me but it becomes more and more easy with experience.
What specific areas of your project would you like help with?Tips for judging which type of display to use for each element.
Community feedback
- P@gabeiPosted about 1 month ago
Nice job! A few things to mention, and hopefully an answer to your question.
-
As far as types of display go, I think you're fine. One thing I would consider is the type of elements you use for the social links on the card. They might be thought of as an unordered list, which is helpful to screen readers when announcing the content ahead. Styling the section as a grid works fine in your case, but I think beginning with a list of links here makes the overall styling a bit simpler in the long run.
-
Check out how
100vh
on the body affects the card's visibility when you switch to landscape mode on a mobile device. This can actually be a quick fix (check out themin-height
property, for example).
Hope this helps. Happy coding!
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord