Design comparison
Solution retrospective
Hi everyone!! ^^
I propose this solution, do not hesitate to give me your opinion, that will allow me to improve because I begin.
Thanks a lot!
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @A-l-i-h-o!
Your solution looks great!
I have a couple of suggestions (about semantic HTML) for improvement:
📌 First: Use
<main>
to wrap the main content instead of<div>
.Tags like
<div>
and<span>
are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.📌 Second: Use
<h1>
for the main title instead of<div>
.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1@A-l-i-h-oPosted 10 months agoHello @danielmrz-dev !
Thank you very much for these very useful tips, I'm going to apply them! It helps me to improve the writing of my code and to have something clean.
Don't hesitate if you have any other suggestions or areas for improvement ^^
1 - The
- @aykinsancakliPosted 10 months ago
Hello @A-l-i-h-o,
Your solution looks great!
📌 A Couple of suggestions:
- After
<body>
tag you can wrap your content inside the<main>
tag. The<main>
HTML element represents the dominant content of the<body>
of a document. This way you are denoting that the part inside the<main>
element is the core content of your website.
- Instead of using generic
<div class="container">
you can use<article>
element that specifies independent, self-contained content (e.g. product card, a forum post).
- Those are Semantic HTML elements and they add meaning to content for better understanding by browsers, developers, and accessibility tools, improving overall web page structure and SEO.
Hope this helps, great work overall!
Cheers,
Aykın
Marked as helpful1 - After
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord