Abdul Khaliq 🚀• 72,660
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
MAKING ACCESSIBLE LINKS:
- The links like
Github
,Frontend Mentor
are needed to be actual<a>
elements which are wrapped up usingli
andul
elements. Thebutton
element is not appropriate to use in this solution. becausebutton
element can't be used for navigation purposes that's why we want to usea
elements.
- This is the current markup,
<div class="buttons__container">
<button class="btn">GitHub</button>
<button class="btn">Frontend Mentor</button>
....
</div>
- In order to make this solution accessible, we need to use
<a>
elements withhref
attribute. Here's the example
<ul>
<li>
<a href="#">Github</a>
</li>
<li>
<a href="#">Frontend Mentor</a>
</li>
...
</ul>
....
- If you have any questions or need further clarification feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
0