Social links profile HTML & CSS

Community feedback

• 

  Svitlana Suslenkova•5,340

  @SvitlanaSuslenkovaPosted 2 months ago

  @media screen and (max-width: 1440px) {... This, I opened it and didn't see half of your css, my screen is bigger... It's better to start from css for mobile screen and add @media for desktop (with min-width). Hope you found this comment helpful :)

  Marked as helpful

  0

  ---

  

  Dev-musty•160

  @Dev-mustyPosted 2 months ago

  Hello @SvitlanaSuslenkova Thanks

  0
• 

  MikDra1•6,960

  @MikDra1Posted 2 months ago

  I encourage you to use this technique to make the card responsive with ease:

  .card {
  width: 90%;
  max-width: 600px;
  }
  

  On the smaller screens card will be 90% of the parent (here body), but as soon as the card will be 600px it will lock with this size.

  Also to put the card in the center I advise you to use this code snippet:

  .container {
  display: grid;
  place-items: center;
  }
  

  Hope you found this comment helpful 💗💗💗

  Good job and keep going 😁😊😉

  1

  ---

  

  Dev-musty•160

  @Dev-mustyPosted 2 months ago

  Hello @MikDra1 Thanks

  0
• 

  P

  Teodor Jenkler•3,760

  @TedJenklerPosted 2 months ago

  Hi @Dev-musty,

  Nice project! I noticed that you're using <div> elements quite a lot. Consider incorporating more semantic HTML elements like <main> to improve accessibility and SEO.

  Also, I see that you’re using <button> elements instead of <a> tags. Remember that <a> tags should be used for links, while <button> elements are meant for actions like submitting a form or triggering a function.

  Additionally, it’s important to use your headings correctly. <h1>, <h2>, and so on should be used in a hierarchical order from most important to least important and then styled with CSS. Note that <h1> should only be used once per page.

  Continue the great work!

  Best, Teodor

  0

  ---

  

  Dev-musty•160

  @Dev-mustyPosted 2 months ago

  Thanks @TedJenkler

  1
• 

  Dev-musty•160

  @Dev-mustyPosted 2 months ago

  Any suggestions on how I can improve are welcome!

  0