Social Links Profile

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

  <div class="social-links">
    <button class="social-link">GitHub</button>
    <button class="social-link">Frontend Mentor</button>
    <button class="social-link">LinkedIn</button>
    <button class="social-link">Twitter</button>
    <button class="social-link">Instagram</button>
  </div>
  
  <ul>
    <li><a>GitHub</a></li>
    <li><a>Frontend Mentor</a></li>
    <li><a>LinkedIn</a></li>
    <li><a>Twitter</a></li>
    <li><a>Instagram</a></li>
  </ul>
  
  

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  • Maby explore downloading the fonts and add them to your CSS with @font-face , Downloading fonts and using @font-face in CSS is beneficial because it improves performance by reducing external requests, provides better control over font styling, and ensures consistent rendering across different browsers and devices.

  Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪

  Marked as helpful

  1

  ---

  

  Lauzy•70

  @K1llaC0dePosted 2 months ago

  @Stroudy Hii, thank you for your comment! I'll fixed my proyect and i'll keep it in mind for future projects.

  1