Darkstar• 1,000
@DarkstarXDD
Posted
- You are using a
<button>inside an<a>. That is not correct. They both have their own use cases. You have to pick the one that suites your use case. A button is used for toggling content (eg: an accordion) or submitting a form. Anchors (links) a used for navigation. Here's a good article for reference: when-to-use-a-button-or-link - In this case it's an anchor styled like a button.
- The location is not a heading. It's a
<p>. - For the blockquote text you can use the
<blockquote>element.
Marked as helpful
0
Alexander Romero• 180
@AlexanderTejedor
Posted
@DarkstarXDD Thanks for you feedback !! Already make the changes ☺️
0
Darkstar• 1,000
@DarkstarXDD
Posted
It's still not correct. Read again what I have said above.
- The clickable items in this design are
<a>. When you click on "GitHub" it will take you to github.com. That's a navigation. Navigations are done using<a>. - Also those set of links are a list.
button-contentshould be an unordered list (<ul>). Github, Linkedin etc. should each be a list item (<li>) inside that<ul>. Inside each<li>there should be an<a>.
<ul class="button-content">
<li><a>GitHub</a></li>
<ul>
0
