Social links profile finished

Community feedback

• 

  Boris•2,870

  @mkborisPosted 3 months ago

  Nice work @Divinitry, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around card. and a footer for the attribution
  • Using an unordered list ul to group the social media links is a better approach for both semantics and accessibility.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.

  Marked as helpful

  2

  ---

  

  Spencer•80

  @DivinitryPosted 3 months ago

  @mkboris

  oh wow, thank you very much for the feedback, will put these to good use!

  1
• 

  MikDra1•6,920

  @MikDra1Posted 3 months ago

  Nice one, @Spencer,

  Here are some tips from me:

  1. You should never make your body height 100vh. Instead you should try to make a container that will have this height.

  2. If you have a font-family always try to add one additional font, like sans-serif, at the end, so if the browser doesn't understand the imported font, it will use the second one.

  3. Next time, try to add a CSS reset to your code. If you don't know how to do it, here is a link for you -> POST and here is also a VIDEO

  If you find this comment useful, please mark it as helpful 💗

  Good job, and keep going 😀😁😉

  Marked as helpful

  1

  ---

  

  Spencer•80

  @DivinitryPosted 3 months ago

  @MikDra1

  Thank you so much for this!

  Another comment here mentioned CSS reset so I will for sure look into this. Do you mind expanding on the first point? What are the drawbacks of making my body 100vh? and instead switching it to a container, what would that accomplish? just wanna learn more, thanks!

  0

  

  MikDra1•6,920

  @MikDra1Posted 3 months ago

  @Divinitry

  Sorry for that I wasn't clear. I meant if you want to you can use height one body, but instead of fixed height you should you min-height so if the content will overflow we will still see it.

  😀😁😊

  Marked as helpful

  0
• 

  Dhruv•210

  @Dhruvmehta1311Posted 3 months ago

  Looks awesome.

  1

  ---

  

  Spencer•80

  @DivinitryPosted 3 months ago

  @Dhruvmehta1311

  thanks!

  0