Design comparison
SolutionDesign
Solution retrospective
Feedbacks are welcome
Community feedback
- P@danielmrz-devPosted 11 months ago
Hello @faizaan-lakd!
Your solution looks excellent!
I have just one suggestion:
- Since they are links to external pages, you could've used the tag
<a>
instead of<button>
. The tag<button>
is generally used for an action inside the page/website.
Use
<a>
for navigation links and accessing external resources, and<button>
for interactive interactions within the page itself, such as submitting forms or triggering JavaScript actions.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - Since they are links to external pages, you could've used the tag
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord