@gmagnenat
Posted
Hi Oliver,
Congrats on completing the challenge!
By reviewing your code, I can give you a few insights that might help you for your next project.
I see that you use at many places margin top or margin bottom on your elements to space them. You could simplify your code by using flexbox and the gap property CSS Tricks - Gap.
In your variable file, I see that you set sizes for the different font-sizes and your name are very specific. I would recommend using generic names instead like : $font-s, $font-m, etc.. and use them appropriately.
For the links, you can add also the focus pseudo class and customize the outline so you'll get the nice greeen/yellow colors when someone is using tab to navigate.
On the design, there are small differences between mobile and desktop. You can add media queries or use fluid value between small and large screen Fluid responsive property calculator
I hope you find these comments helpful. Let me know if you have any questions.
Marked as helpful
@olivervillalobos
Posted
@gmagnenat I really appreciate your feedback, I'll take a look to the link you shared. I would read some articles for variable names since this is not the first time someone mention this.
Thank you so much :)
