@krushnasinnarkar
Posted
Hi @DarkstarXDD,
Congratulations on successfully completing the challenge! Your code is well-structured, and the website works beautifully across different screens. You've done an excellent job ensuring responsiveness and functionality.
Your HTML structure is quite good, but it can be enhanced by using more semantic tags and ensuring proper accessibility. Here are some improvements:
- Use
<header>
for the profile header. - Use
<section>
for grouping related content (profile header and description). - Use
<nav>
for the links, as they are navigational elements.
You can check W3Schools Semantic Elements to learn more about semantic elements and improve your HTML structure.
I hope you find this helpful, and I would greatly appreciate it if you could mark my comment as helpful if it was.
Feel free to reach out if you have more questions or need further assistance.
Happy coding!
@DarkstarXDD
Posted
@krushnasinnarkar
Thanks, but I don't think any of the mentioned points are valid for this component.
<header>
should be used for content that is repeating across multiple pages. This is a component, which doesn't need a<header>
. banner landmark<section>
is a meaningless element just like a<div>
unless you have labeled it. So no need to replace a<div>
with a<section>
unless you prefer it.<nav>
is used to navigate the content inside the site. Not for external links. Having the links as list items is enough in this case. navigation landmark