Social links profile

Community feedback

• 

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Hello again, Fantastic effort on this! You’re really nailing it. Just a few things I noticed that could make it even better…

  • I would put these into a <ul> <li>, and the text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

          <div class="links">
            <a href="https://www.github.com" class="link">GitHub</a>
            <a href="https://www.frontendmentor.io" class="link"
              >Frontend Mentor
            </a>
            <a href="https://www.linkedin.com" class="link">LinkedIn</a>
            <a href="https://www.twitter.com" class="link">Twitter</a>
            <a href="https://www.instagram.com" class="link">Instagram</a>
          </div>
  

  • Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  0

  ---

  

  P

  Zxjklp•90

  @ZxjklpPosted about 2 months ago

  Hello @Stroudy,

  I really appreciate the time you took to review my project and provide these valuable suggestions. Your feedback has been incredibly helpful, and I am excited to continue improving my skills.

  1

  

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Hey @Zxjklp, You did very well, Hard for me to provide any feedback! Keep up the great work! You got this!

  0