Design comparison
Solution retrospective
Hello !
I'm pleased with the colours chosen and the way the result looks.
What challenges did you encounter, and how did you overcome them?The difficulty for me on this challenge was to properly organize this list of links by getting rid of the styles inherent to the , , and elements. Also, with my manipulations, I realize that I can't make the cursor appear when I hover over my links. I've tried cursor: pointer, but it's not working.
What specific areas of your project would you like help with?I'm open to any suggestions and advice.
Community feedback
- @grace-snowPosted 8 months ago
Here's some suggestions
- Your name should be a h1 I think. Every page needs a h1 and that would be appropriate for it. Alternatively add a visually hidden h1 above.
- The text that starts "Aspiring..." needs to be in a paragraph.
<q>is not a meaningful element on its own. To be honest it doesn't read like a quote at all. - If you are going to make links open in a new window you must notify users, especially screen reader users, of this behaviour. Usually this is done with some visually hidden text inside the link that says "(opens in a new tab)". Optionally you could include an icon to indicate the non-standard behaviour to sighted users as well.
- The cursor style should be on links by default not only when hovered.
- The img border radius can be set as 100% for circles.
- There is no need to wrap the heading and paragraph in a div. Only add necessary html.
0@matbac85Posted 8 months ago@grace-snow
Again, Grace, thank you for your thorough feedback. I will correct my code tomorrow following your remarks. Thank you very much. I am learning a lot thanks to you.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord