Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Links Profile Component by Pulfer Dadson

Pulfer Dadsonβ€’ 120

@justPulfer

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback would be appreciated.

Community feedback

Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @justPulfer!

Your project looks great!

I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

πŸ“Œ Apply this to the body (in order to work properly, don't use position or margins):

body {
    min-height: 100vh;
    display: flex;  /* it works with grid too  */
    justify-content: center;
    align-items: center;
}

I hope it helps!

Other than that, great job!

Marked as helpful

0

Pulfer Dadsonβ€’ 120

@justPulfer

Posted

Thanks so much. @danielmrz-dev . I always wanted to know the optimal way to center divs. You sometimes don’t find optimal solutions on the internet because of the vast input from all kinds of sources. I appreciate it.

1
Irwingβ€’ 200

@Irwing-Dev

Posted

Hi Pulfer! πŸ‘‹

Your solution is good!

However, there's one thing I'd recommend you add:

  • The site has a horizontal and vertical scroll bar. You can improve this, you just need to add a height value to your container class:
.container {
// Your CSS
height: 95%; 
}

This makes the scroll bar disappear and the card retains its great appearance on the site

I hope this helped.

Other than that, good job, I wish good luck in your studies and bye bye!!πŸ‘‹πŸ‘‹

0

Pulfer Dadsonβ€’ 120

@justPulfer

Posted

@Irwing-Dev . Thanks for the input. I’ll double check. I tested it so many times but didn’t come across that issue. Anyways thanks for the notice.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord