Social Links Profile Component by Pulfer Dadson

Community feedback

• 

  Daniel 🛸•44,270

  @danielmrz-devPosted 9 months ago

  Hello @justPulfer!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0

  ---

  

  Pulfer Dadson•120

  @justPulferPosted 9 months ago

  Thanks so much. @danielmrz-dev . I always wanted to know the optimal way to center divs. You sometimes don’t find optimal solutions on the internet because of the vast input from all kinds of sources. I appreciate it.

  1
• 

  Irwing•200

  @Irwing-DevPosted 9 months ago

  Hi Pulfer! 👋

  Your solution is good!

  However, there's one thing I'd recommend you add:

  • The site has a horizontal and vertical scroll bar. You can improve this, you just need to add a height value to your container class:

  .container {
  // Your CSS
  height: 95%; 
  }
  

  This makes the scroll bar disappear and the card retains its great appearance on the site

  I hope this helped.

  Other than that, good job, I wish good luck in your studies and bye bye!!👋👋

  0

  ---

  

  Pulfer Dadson•120

  @justPulferPosted 9 months ago

  @Irwing-Dev . Thanks for the input. I’ll double check. I tested it so many times but didn’t come across that issue. Anyways thanks for the notice.

  0