Community feedback

• 

  Kalpesh Patil•150

  @kalpesh172000Posted 2 months ago

  Good things

  • Really nice and clean code.
  • Solution looks really close to design.
  • Design is responsive.
  • This is first time ever that I have seen nesting in css. I'll research more about it.

  what can you improve

  • As you have used flexbox for body tag the content clips at top and bottom when height shrinks too much. To avoid this give min-height to the body so when height shrinks too much it makes the body scrollable and card won't clip.
  • After doing that add 24px padding to body for nice touch.

  Marked as helpful

  1
• 

  Craig Johnson•260

  @craigdev937Posted 2 months ago

  Great job on finishing the challenge. One thing that you might consider is to change the color for the hover.

  &:hover {

   background-color: var(--green);
  

  }

  That way it stands out. Keep up the great work!

  Marked as helpful

  1

  ---

  

  Tarik Raposo Parreira•80

  @tarikraposoPosted 2 months ago

  @craigdev937 Thanks, I forgot the hover.

  1