Social links profile challenge solution
Design comparison
Solution retrospective
I am able to build a responsive webpage
What challenges did you encounter, and how did you overcome them?I didn't encounter any challenges
What specific areas of your project would you like help with?How can i increase the performance
Community feedback
- @Dav1dGPPosted 6 months ago
Hi aryakrishnaksh2021 !
Good job completing this challenge !!!!
Two little things I have to comment:
First, the media query rules seem to have overlapping ranges. For example, you have one media query for screens between 480px and 371px and another for screens below 370px. But the media query for 480px to 371px would already apply to all screens below 480px, which makes the second media query redundant.
Notwithstanding the above, for this project it is not necessary to use media queries.
Finally, if links are expected to redirect to external pages or different parts of the website, it would be more semantic and accessible to use a <nav> element along with the corresponding links.
I hope these comments help!
Good luck and enjoy typing!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord