Skip to content
Submitted 8 months ago

Social links profile card using Flexbox

Ayush Yadav•140
@ayushyadavz
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

Proud that i made somehow same as the preview image.

What challenges did you encounter, and how did you overcome them?

I'm in doubt that this is not responsive, so if anyone can review my code and tell what changes should i make then it would be helpful for me.

Community feedback

  • Øystein Håberg•10,390
    @Islandstone89Posted 8 months ago

    HTML:

    • Headings should always be in order, so you never start with a <h3>. Change it into a <h1>.

    • I see the links as an unordered list.

    CSS:

    • Always include a CSS Reset at the top.

    • You have declared 0 padding and margin on * twice.

    • Move font-family to body.

    • Remove width on body - it is 100% wide by default.

    • Remove the width on the card. you should rarely set fixed sizes. Instead, give it a max-width in rem.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord