Adriano• 36,850
@AdrianoEscarabote
Posted
Hi Manish Chavan, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:
A tip to improve the semantics of the code would be to use ul, since that is a list of links:
<ul>
<li><a href="#">GitHub</a></li>
<li><a href="#">Frontend Mentor</a></li>
<li><a href="#">LinkedIn</a></li>
<li><a href="#">Twitter</a></li>
<li><a href="#">Instagram</a></li>
</ul>
The rest is excellent.
I hope you find it useful. 👍
Marked as helpful
0
Manish• 90
@manish2120
Posted
@AdrianoEscarabote
Oh, I was thinking about this too. I saw that some people use <li> elements, but I wasn't sure why. i just researched about this right now...
Let me know am i correct now:
- Using <li> makes sense here because we have a group of social media links.
- Anchor tags are used as separate links, when they aren't connected or in different contexts.
And yess thanks for feedback! 🙂
0
Adriano• 36,850
@AdrianoEscarabote
Posted
@manish2120 Yeah, you're right !
0
