Social links profile card

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Greetings! you have done a great job 😎

  📌 Some accessibility and semantics recommendations for your HTML

  • To improve the semantics of your HTML, you can change your <div class="attribution"> to a <footer class="attribution">
  • To center the content you do not need margin: auto. You can use min-height: calc(100vh - 16.5px) to make the main and footer enter the screen without generating a vertical scroll

  0

  ---

  

  Imran•150

  @xdevimranPosted 10 months ago

  @Blackpachamame Thank you so much, I'm working on it and will fix it. Have a good day Marcos

  0

  

  Imran•150

  @xdevimranPosted 10 months ago

  just update the code can you please check the updated code, as you say I tried to implement the semantics HTML and also remove margin: auto @Blackpachamame

  0

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  @xdevimran Looks good, but apparently min-height: calc(100vh - 16.5px) doesn't work in tailwind, it should be min-h-full for min-height: 100vh and min-h-[220px] (example), for a custom value.

  However, it seems to me that tailwind does not accept min-h-[calc(100vh - 16.5px)] as valid. Maybe if you add it as a custom value in tailwind.config.js it will work.

  Marked as helpful

  0