Social Links Profile

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 9 months ago

  Hello @Masood-zone!

  Your project looks great!

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  0
• 

  Marzuk Sanni•1,360

  @ZukizukPosted 9 months ago

  Hello there, Congratulations on completing this project

  Your solution looks nice

  I have few suggestions that I think might be of interest to you.

  - HTML: Consider using semantic HTML tags like <main></main>,<section></section> and others that you can find in this link. And in this case, replace the <div> with <main>. the main tag should hold the main content of the page so consider correcting that.

  The semantic HTML tags help the search engines and other user devices to determine the importance and context of web pages. The pages made with semantic elements are much easier to read. It has greater accessibility. It offers a better user experience. Using div when there's a better alternative is not a good practice as div hold no semantic value.

  Also you didn't use <a href=""></a> for the links, whenever you have a link in a page make sure you use anchor tag. So in this situation you should put the a tag in the ul li tag like this.

  <ul>
        <li><a href="">Github</a>
  </ul>
  

  Also I didn't see you use <h1> tag in your page, you should note that every page should contain <h1></h1> and there should be only one of it. It can't be two so note that

  I hope this feedback is helpful

  Other than that great job

  0