@DylandeBruijn
Posted
Hi @trskldnt,
Great job on another finished project, you're on a roll! Nice use of CSS variables and proper class names.
Some friendly constructive feedback:
-
Instead of using
height
try usingmin-height
or justpadding
for the buttons. When you set theheight
of a button to a fixed value you get overflow issues when the text of the button gets too large. You can see this problem as well when you make the viewport really small. -
Try experimenting with relative units like
rem
andem
. They help you make your solution responsive. More information here. -
Instead of using
border-radius: 999px;
to make the image round you could useborder-radius: 50%
. Just for your interest. -
Instead of using
row-gap
you can just usegap
. If I remember correctlyrow-gap
is used in combination withgrid
if you just want to set thegap
on the rows and not the columns.
I hope you find my feedback helpful and if you have any other questions ask away!
Marked as helpful