Social Links Profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 4 months ago

  Hey @lalaholmesss!

  Congrats on finishing the challenge! ✅

  Your solution looks awesome!

  📌 It's a good idea to use semantic HTML elements like <ul> and <li> for lists. This makes your code more accessible, maintainable, and meaningful.

  Here's an example of how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  Using <ul> and <li> makes your content structure clearer, which is better for screen readers and search engines. Plus, it follows best practices for HTML.

  📌 Also, using margin and/or padding isn't always the best way to center an element. Try this method to center an element vertically and horizontally:

  📌 Apply this CSS to the body (skip position or margins to make it work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  Hope this helps!

  Keep up the great work!

  Marked as helpful

  0