Design comparison
Community feedback
- @Alex-Archer-IPosted 6 months ago
Hi! Very neat work, great job =)
I can give you a couple suggestions. You can apply flex to
body
tag - it'll provide better centering. Also don't forget aboutalt
attribute of theimg
tag. That is considered good practice cos image description fromalt
used by screen readers and browsers if picture didn't load.And in the end - that's cool that you are using
width
+max-width
approach for the.profile
element. But50vw
is not the best choice here. For example, if someone open your page with 375px wide screen the width of this element will be 187.5px. Try something like this:main { width: 95%; man-width: 400px; }
I hope something of that will be useful =) Good luck =)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord