@DylandeBruijn
Posted
@margaux-works
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution 🎉
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve ✍️
-
I suggest adding a bit of
paddingto yourbodyelement so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vhto yourbodyelement so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try using using relative CSS units like
remandemthey make your layout more adaptable. -
Try putting your links in a list (
ul) to make your code more semantic. -
You don’t have to wrap your image in a separate
div, it’s possible to style it directly to achieve the same result. -
To make your image round you can also write
border-radius: 50%instead ofborder-radius: 999px. -
Try experimenting with the Flexbox
gapproperty.
I hope you find my feedback helpful! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
@DylandeBruijn
Hi Dylan,
thank you so much for the super detailed feedback, I really appreciate it 🤟🏻
I have implemented all the optimisations you suggested, that was fun :) I am happy I could update my code with REM (first time using them properly) without running into any issue.
For the gap property, I was already using it on the social-links class. Do you see any other places where I could be using it?
Thank you again 🙏🏻
Cheers, Margaux
