Social Links Profile

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @margaux-works

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Use of semantic HTML elements
  • Clear descriptive CSS classes
  • Use of CSS custom properties

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • You could add a min-height: 100vh to your body element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.

  • Try using using relative CSS units like rem and em they make your layout more adaptable.

  • Try putting your links in a list (ul) to make your code more semantic.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

  • To make your image round you can also write border-radius: 50% instead of border-radius: 999px.

  • Try experimenting with the Flexbox gap property.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  0

  ---

  

  P

  Margaux•150

  @margaux-worksPosted 4 months ago

  @DylandeBruijn

  Hi Dylan,

  thank you so much for the super detailed feedback, I really appreciate it 🤟🏻

  I have implemented all the optimisations you suggested, that was fun :) I am happy I could update my code with REM (first time using them properly) without running into any issue.

  For the gap property, I was already using it on the social-links class. Do you see any other places where I could be using it?

  Thank you again 🙏🏻

  Cheers, Margaux

  1