Design comparison
SolutionDesign
Community feedback
- @LarisaKampePosted 3 months ago
Hello there!
I love the white line separation detail you have added. But It needs a bit of the room to breath if you want to keep the attribution part inside the card, just some visual detail. :)
Here are a few suggestions for your HTML:
- You can put the body content inside the <main> element as it represents the dominant content of the <body> of a document. Every webpage needs a <main> that wraps all of the content, except for <header> and <footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section.
- Make sure your class naming is consistent throughout your code, to make it easier to maintain and for others to follow.
- Keep your code tidy, fix formatting.
And some suggestions for CSS: Love the button animation! :D I would personally put the padding-bottom on the container to be at least 40px.
Keep up the awesome work!
Marked as helpful0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord