Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social-links-profile

P
Mohd Sadaf 460

@MsadafK

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Mohammad-Moneer

Posted

Hello there, You made a good solution 👍 Your code is well-structured and easy to read.

Suggestions for Improvement:

CSS Variables:
    Consider using CSS variables for colors and other repetitive values. This will make your code more maintainable and easier to update in the future. For example:

    css

:root {
  --green: hsl(75, 94%, 57%);
  --white: hsl(0, 0%, 100%);
  --grey: hsl(0, 0%, 20%);
  --dark-grey: hsl(0, 0%, 12%);
  --off-black: hsl(0, 0%, 8%);
}

body {
  background-color: var(--off-black);
  color: var(--white);
}

.card-container {
  background-color: var(--dark-grey);
}

.location {
  color: var(--green);
}

a {
  color: var(--white);
  background-color: var(--grey);
}

a:hover {
  background-color: var(--green);
  color: var(--grey);
}

Again, great job on your project! I hope you find this suggestion helpful.

Marked as helpful

1

P
Mohd Sadaf 460

@MsadafK

Posted

@Mohammad-Moneer next time, i ll keep that in mind what u have suggested and thankyou for your kind feedback 😊

0
chrisk71 40

@chrisk71

Posted

Hi @MsadafK,

Good attempt! Try adjusting the container size to match the design. You should create an unordered list for your links in your HTML file:

<ul>
<li><a href="#">Github</a></li>
<li><a href="#">Frontend Mentor</a></li>
<li><a href="#">LinkedIn</a></li>
<li><a href="#">Twitter</a></li>
<li><a href="#">Instagram</a></li>
</ul>

Good luck!

1

P
Mohd Sadaf 460

@MsadafK

Posted

@chrisk71 thankyou for your kind feedback 😊

0
Steven 130

@Steven-Ang

Posted

Looks good

1

P
Mohd Sadaf 460

@MsadafK

Posted

@Steven-Ang thankyou for your kind feedback 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord