Social-Links-Profile

Community feedback

• 

  Stefan W.•130

  @stewil87Posted 7 months ago

  Hello H-Keshk,

  nice to see your solution to the challenge.

  I would the first div, to have a class which describes the module you style like a ".card" or something similar. so the div wouldn't be :first-child, but div.card. So you'll be able to other divs on the page, than only that one.

  You should use a button only, when there is a real action, like open/close/formsubmit anything like that and for the profile links, a list ul/li with a tag links in each child.

  in image alt tag, dont use 'image of/picture/image'. For the screenreader and user it is already known that its an image.

  instead of have that many different sizes for the overall card, it might be, without media queries, enough to have width: min(380px, 100%); which basically means, the element will be width: 380px, if there is enough space, otherwise 100% width.

  Marked as helpful

  0