Social links Profile

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  MAKING ACCESSIBLE LINKS:

  • The links like Github, Frontend Mentor are needed to be actual <a> elements which are wrapped up using li and ul elements. Because we need to use semantic elements to improve accessibility of our solution.

  ---

  • This is the current markup,

    <button>Github</button>
    <button>Frontend Mentor</button>
    <button>LinkedIn</button>
    ...
  

  ---

  • In order to make this solution accessible, we need to use <a> elements with href attribute instead of button. Here's the example

  <ul>
      <li>
         <a href="#">Github</a>
      </li>
      <li>
         <a href="#">Frontend Mentor</a>
       </li>
      ...
  </ul>
  ....
  

  ---

  • If you have any questions or need further clarification feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Mine•90

  @MineshayePosted 6 months ago

  Thank you @0xabdulkhalid for the correction

  0

  

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted 6 months ago

  @Mineshaye Glad you found it helpful ! 🤠

  0