Social-Links-Profile

Community feedback

• 

  Boris•3,120

  @mkborisPosted 3 days ago

  Great work, the height: 100vh on the .container makes the container to be kind of cut off from the viewport, change it to min-height: 100vh. Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues. Ideally, it's better to apply this style to the body element rather than the .container.

  Also, to improve the semantic meaning of these social media links, you should use the a tag instead of the button tag. The a tag is used for navigation to other pages, while the button tag is designed for interactive actions like submitting forms or for events like toggling content.

  Hope this helps, Good luck!

  Marked as helpful

  1

  ---

  

  Will Cooley•30

  @CooleyWCPosted 2 days ago

  @mkboris Thanks! Very detailed and helpful!

  1