Yusuf• 90
@yusufskebbe
Posted
Awesome job, pixel perfect well done
Marked as helpful
1
yesim• 170
@ysmltr
Posted
@yusufskebbe thanks yusuf!
1
Design comparison
Solution retrospective
Any opinion would be very helpful!
Community feedback
Daniel 🛸• 44,230
@danielmrz-dev
Posted
Hello @ysmltr!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>to wrap the main content instead of<div>.
📌 Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.
This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
1
yesim• 170
@ysmltr
Posted
@danielmrz-dev it really helps daniel thank you so much!
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord