py-code314• 290
@py-code314
Posted
Hello,
Nice job on the project. I think it's very close to the design specifications.
I would like to point out a few things if you don't mind.
- When the screen size is narrower than 400px, card content is hiding behind the screen edge. I suggest you change
width
on.card
tomax-width
to make it flexible - There's a thin blue outline around the links when I focus them with TAB. You can remove this with
outline: none
if you want - I think it's better to use
<p>
and<blockquote>
tags for.card__profile_location
and.card__profile_bio
as they describe the content more accurately - I also noticed that you used
<div>
s to wrap social media links. You should put them in<a>
tags as they are links when clicked take the user to another page. In addition you can put all links in a<ul>
element if you want - No need to use
width
on body as it may add scrollbar sometimes. Also it's a good practice to usemin-height
instead ofheight
on body
Hopefully these points will help you to make it better. All the best!
Marked as helpful
1