Social Links Profile

Community feedback

• 

  Gautam Sarkar•850

  @gautam32b7

  Posted about 1 year ago

  Hi Angela

  Nice work! I have feedback on two topics: CSS units and the transition property. Every user sets their font size to a different size. It is a better practice to set the font size to 10px in the root. html { font-size: 62.5% }

  Use rem instead of px.

  Transition: Transition allows to change the property values smoothly over a given duration. So when using the hover property over an element it is good to apply transition in the parent.

  Example

  button { padding: 1rem 2rem; font-size: 1.6rem; background-color: red; transition: all 0.3s ease; }

  button:hover{ background-color: green }

  Hope you find this helpful.

  10

  Marked as helpful