Social links profile

Community feedback

• 

  Tharun Raj•1,330

  @Code-BeakerPosted 6 months ago

  Hi there, congratulations on completing this project. You've done a great job! 🎉

  Your project looks good and you've tried to get it close to the design. I have some suggestions regarding your project that might help you improve it.

  • the social links must be created using anchor tags because they're links. currently they're list items that are inside a ul. I recommend to change it to something like the code-block below with your classes/ids.

  <ul>
    <li>
      <a href="#">GitHub</a>
    </li>
  </ul>
  

  • on hovering the links, the text is not readable. Consider using a darker color instead of white. A more appropriate and contrasty color would be the `
  • use a min-height instead of height for the container. height: 100vh will restrict the height of the container on mobile phones and the website will not be responsive.

  .container {
    min-height: 100vh;
  }
  

  • use CSS variables or custom properties in projects like this. It will help you in not remembering the color's hex/hsl codes everytime.

  Example:

  for the dark background color, create a variable like this:

  :root {
    --dark-color: hsl(0, 0%, 8%);
  }
  

  to use it, simply use:

  body {
    background-color: var(--dark-color);
  }
  

  If you wish to learn more about this topic, check out this article from MDN

  I hope this helps you learn something new 😊

  Marked as helpful

  0

  ---

  

  Risa2422•180

  @Risa2422Posted 6 months ago

  @Code-Beaker Thank you so much for your feedback! It was really helpful.

  1