Social Links Profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 6 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your solution looks great!

  📌 It's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  0
• 

  Ashong•930

  @AshongAbdallah06Posted 6 months ago

  Yes, the layout for the button and anchor tags are corrected. In the styles, its mostly encouraged to use classes (.class) instead of ID's (#id).

  Personal opinion: I like to use imports for the fonts and then put the font-family property on the universal class like this, when I'm only using 1 font, so that it affects everything, including buttons. As far as I've observed, buttons are not affected by the fonts unless specified in their styles.

  @import("link to specific google font");
  * {
      font-family: "font here"
  }
  

  I hope this makes sense.

  0