Social links profile

Community feedback

• 

  P

  Steven Stroud•11,890

  @StroudyPosted 3 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Your links are inaccessible from assisted devices making it not accessible, You can change this with a <a> or tabindex attribute,
  • Missing a <meta> description tag for SEO purposes,
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

  Would like to see some variables being used on your next challenge, I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0