@Stroudy
Posted
Exceptional work! You’re showing great skill here. I’ve got a couple of minor suggestions that could make this stand out even more…
-
Using a
<main>tag inside the<body>of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. -
Overusing
<div>tags, known as "divitis," leads to cluttered code, poor semantics, and reduced performance. Instead, use appropriate semantic elements (like<header>,<section>, etc.) to improve readability, accessibility, and SEO. Keep HTML clean and minimal to ensure maintainability, scalability, and better CSS structure.
<div class="card">
<div class="inner-border">
<div class="content">
<div class="img">
-
Every page should have atleast one
<h1>< -
For future project, You could download and host your own fonts using
@font-faceimproves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
-
While
pxis useful for precise, fixed sizing, such asborder-width,border-radius,inline-padding, and<img>sizes, it has limitations. Pixels don't scale well with user settings or adapt to different devices, which can negatively impact accessibility and responsiveness. For example, usingpxfor font sizes can make text harder to read on some screens, Check this article why font-size must NEVER be in pixels. In contrast, relative units likeremand adjust based on the user’s preferences and device settings, making your design more flexible and accessible. Usepxwhere exact sizing is needed, but prefer relative units for scalable layouts. If you want a deeper explanation watch this video by Kevin Powell CSS em and rem explained. Another great resource I found useful is this px to rem converter based on the default font-size of 16 pixel.
I hope you’re finding this guidance useful! Keep refining your skills and tackling new challenges with confidence. You’re making great progress—stay motivated and keep coding with enthusiasm! 💻
@Pichikachandu
Posted
Thank you so much @Stroudy for your guidance i will rectify those mistakes from future challenges onwards
@Pichikachandu apply them all here first
@Pichikachandu there is actually even more important feedback than @stroudy has left here, as important as all that is.
It is essential you learn how to translate a design into appropriate meaningful html elements. This design shows a list of links. But you have written it as lots of divs with headings inside. This doesn’t make sense when you think about it. They are not headings for any other content. They are clearly functional, they need to be clickable and navigate people to these sites. That means this must be a list of links.
There’s not a lot of other meaningful structure needed on this. Remove all the divs and br. This challenge should only be
- a
mainlandmark. - a div for the card.
- img (with empty
altattribute because the description is not bringing any extra value to this content). - heading
- two paragraphs
- a list
- a link inside each list item
Marked as helpful
@Pichikachandu
Posted
Yeah sure @grace-snow I learned a lot from your comment
@Pichikachandu
Posted
okay i will apply now@grace-snow
@Stroudy
Posted
Hey @Pichikachandu, No problem we have all been here, You got this! 💪
Marked as helpful
@Pichikachandu
Posted
okay@Stroudy
