Design comparison
Solution retrospective
Which areas of your code are you unsure of?
Classes: the project only has one element each. Should I still give them classes? Generally the layout of code. Are they okay?
Do you have any questions about best practices?
Any tips appreciated. Will read thoroughly through each one.
Community feedback
- @FernJBatistaPosted 9 months ago
Hi there!
I think you did great for this project!
The only suggestions I'd have for you is using semantic HTML. For example, you used a div and gave it the class "main-container", but you could just use the <main> tags and that also helps the browser understand where the main information is.
The only other thing I noticed is that you didn't use heading hierarchy, so you used h4 and h5 without using any of the higher hierarchy headings. It's good practice to have an h1 always and then follow the chain of headings. This was weird for me at the beginning, but it's more about the HTML structure than the styling.
Other than that, I think you did really good on this project!
Keep it up, happy coding!
Marked as helpful2@BuraYuPosted 9 months ago@FernJBatista
Thank you very much! I appreciate your time and feedback.
I will have to look more into HTML semantics and heading hierarchy.
1
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord