Hi, @dpiskov. That's a good solution. Keep coding. Here are some tips for you:
- You don't need to use the
span
element for the text, you can use thep
element instead of thespan
like this:<span>London, United Kingdom</span>
<p>London, United Kingdom</p>
- You can use the
a
element instead of thebutton
. The anchor element is more semantic than the button, especially when used within the list items.<li><button>GitHub</button></li>
<li><a href="#">GitHub</a></li>
- You don't need to use the
display: grid;
rule for list items.Grid
has no effect on the grid-container and grid-items when you don't use any grid features, it doesn't work like theflex
. You should assign some declaration if you want to use grid features. So, in this scenario, it doesn't have any impact on your items. Usea { display: block; }
declaration to give thea
elements some padding and margin.
I hope these will help you. Keep coding and have a nice day
Marked as helpful
0
dpiskov• 50
@dpiskov
Posted
@adonmez04 Thank you! I appreciate your helpful feedback!
1