Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Links Profile

dpiskov 50

@dpiskov

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'd appreciate any suggestions on how to improve this if any :)

I'm new to html and css so I'll appreciate any advice on how to improve my skills.

Community feedback

P
Alper 1,010

@adonmez04

Posted

Hi, @dpiskov. That's a good solution. Keep coding. Here are some tips for you:

  • You don't need to use the span element for the text, you can use the p element instead of the span like this:
    • <span>London, United Kingdom</span>
    • <p>London, United Kingdom</p>
  • You can use the a element instead of the button. The anchor element is more semantic than the button, especially when used within the list items.
    • <li><button>GitHub</button></li>
    • <li><a href="#">GitHub</a></li>
  • You don't need to use the display: grid; rule for list items. Grid has no effect on the grid-container and grid-items when you don't use any grid features, it doesn't work like the flex. You should assign some declaration if you want to use grid features. So, in this scenario, it doesn't have any impact on your items. Use a { display: block; } declaration to give the a elements some padding and margin.

I hope these will help you. Keep coding and have a nice day

Marked as helpful

0

dpiskov 50

@dpiskov

Posted

@adonmez04 Thank you! I appreciate your helpful feedback!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord