Design comparison
Solution retrospective
After my previous two challenges, I spent some time learning how to use em and rem units and I feel as though I have finally have a grasp on how to use them. I also did some research into focus states, as I wasn't sure what the difference was between :hover and :focus. I have learned how to properly customise a website to not only make it pretty, but to help with basic keyboard accessibility.
What specific areas of your project would you like help with?I will be trying to incorporate more website accessibility into my code. Early on in my web development journey I touched on this subject through freeCodeCamp, but now that I have a better grasp on the basics of HTML and CSS, I think I will have a better time understanding these concepts and how to use them.
Community feedback
- @aurelienfliegerPosted 24 days ago
Pros:
- good use of rem units
- well articulated class names
- appropriate use of links
- faithful to the original design
Cons:
- in the CSS, you define the root font size (in "html") as 0.9em - since this is the root font size, it cannot be relative to anything else and must therefore be in pixels
- some of the texts are not in bold in your version yet should be
- the spacing is incorrect between the photo, name and address
- you use divs in your HTML where you should be using semantic elements. This hurts accessibility.
keep doing what you're doing kiddo
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord