Design comparison
Community feedback
- @StroudyPosted about 2 months ago
Wow the closest I have seen this solution to the design, Hello again fellow coder, fantastic effort on this! You’re really nailing it. Just a few things I noticed that could make it even better…
-
Using
font-display: swap
in your@font-face
rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear. -
This does not matter that much at this stage but something to be mindful of for SEO(Search Engine Optimisation),
<meta>
description tag missing that helps search engine determine what the page is about, Something like this<meta name="description" content="description goes here" />
-
Still on on some elements you are using
px
to be consistent you should userem
like the rest of your CSS. -
Using
rem
orem
units in@media
queries is better thanpx
because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.
You really smashed this challnege, I am glad you have taken my feedback on board!, I hope you found this advice helpful again! Keep up the great work, You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord