Skip to content
Submitted 8 months ago

Social links profile

Maximilian Dybvik•200
@RegexRiddler
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Social links profile
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm happy with the design accuracy.

What challenges did you encounter, and how did you overcome them?

I wanted to forgo any media query bu using the clamp function on my card padding, however clamp seems to not work on padding. I ended up using media query to set my paddings.

What specific areas of your project would you like help with?

All of my links are "span" elements as children of a "div". Is it ok to use "span" when making call to action buttons or is the "button" element preferred?

Community feedback

  • Account deleted

    Well done on the project, @RegexRiddler.

    I recommend replacing the span tags inside the social links container with hyperlinks (<a href="#"></a>). Since they are social links, they should link to the social media page.

    Otherwise, well done!

    Marked as helpful
    1
    Maximilian Dybvik•200
    @RegexRiddlerPosted 7 months ago

    @complic8-coder Thank you, valid point! I have implemented your suggestion and reflected the changes to my repo :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord