Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Social Links Profile

Olu Dev.Itā€¢ 90

@OluDevIt

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P
solvmanā€¢ 1,670

@solvman

Posted

Very well done! šŸŽŠšŸŽ‰šŸš€

I like how you properly use h2. Remember, heading levels represent levels of heading subsections, not typographical decoration. It would be best if you did not skip sections; h1 should be followed by h2 and so on. In this project, you could temporarily add a visually invisible h1 element to avoid breaking hierarchy rules. You may read more about heading hierarchy in HTML - Live Standard - Headings

Visually hidden class for the h1

.visually-hidden {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px;
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border: 0;
}

Use should look into using more semantic HTML instead of plain <div> elements for better accessibility. Consider replacing <div> elements with <section> semantic elements to divide your HTML document logically. You may use the <article> element to wrap the card and the button element to represent buttons. Consider wrapping everything with the <main> element. For example:

   <main>
      <h1 class="visually-hidden">Profile card project</h1>
      <article class="card">
        <session class="profile">
          <img
            src="./assets/images/avatar-jessica.jpeg"
            alt="avatar"
            class="profile__img" aria-hidden="true"
          />
          <h2 class="profile__name">Jessica Randall</h2>
          <p class="profile__location">London, United Kingdom</p>
          <p class="profile__description">
            "Front-end developer and avid reader."
          </p>
        </div>
        <div class="socials">
          <button class="button">GitHub</button>
          <button class="button">Frontend Mentor</button>
          <button class="button">LinkedIn</button>
          <button class="button">Twitter</button>
          <button class="button">Instagram</button>
        </div>
      </div>
    </main>
  </body>

You may read more about section and sectioning content in the following articles:

ā­ļø HTML - Living Standard - Sections

ā­ļøHTML - Living Standard - Sectioning content

Also, I noticed that your :hover does not change the background of the buttons, which could be achieved like this:

.button:is(:hover, :focus) {
  background-color: hsl(75, 94%, 57%);
  color: hsl(0, 0%, 20%);
}

You could add a transition property to the button to make the color transition more visually enjoyable.

button {
     transition: all 0.4s;
}

Otherwise, very well done! šŸš€ Impressive! šŸŽ‰ Keep it up! šŸ‘

Marked as helpful

0

Olu Dev.Itā€¢ 90

@OluDevIt

Posted

Thank you for the feedback, its appreciated @solvman

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord