
Design comparison
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@Stroudy
Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…
-
Having a clear and descriptive
alt
text for images is important because it helps people who use screen readers understand the content, making your site more accessible. It also improves SEO, as search engines usealt
text to understand the image's context, helping your site rank better, Check this out Write helpful Alt Text to describe images, -
For future project, You could downloading and host your own fonts using
@font-face
improves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. Place to get .woff2 fonts -
Developers should avoid using pixels (
px
) because they are a fixed size and don't scale well on different devices. Instead, userem
orem
, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter. -
Using
max-width: 100%
ormin-width: 100%
is more responsive than justwidth: 100%
because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning. -
Using a full modern CSS reset is beneficial because it removes default browser styling, creating a consistent starting point for your design across all browsers. It helps avoid unexpected layout issues and makes your styles more predictable, ensuring a uniform appearance on different devices and platforms, check out this site for a Full modern reset
I hope you found this advice helpful! Keep up the great work, You’re doing amazing, and I can’t wait to see what you create next. Happy coding! 🚀
Marked as helpful -
- @MohammedOnGit
Hello Sergey Juchenko!
Your "Social links profile" page looks great in terms of structure. Here are a few suggestions for improving it based on web development best practices:
- Accessibility Enhancements Alt Text for Image: Ensure the alt attribute for the image has a meaningful description for users relying on screen readers. If it’s a decorative image, you can use alt="", but if it’s a profile image, you could write something like alt="Profile picture of Jessica Randall".
Link Descriptions: It’s a good practice to make your links descriptive. For example, instead of just “GitHub,” you could say “Jessica’s GitHub profile” to provide more context for accessibility:
<li><a href="#">Jessica's GitHub Profile</a></li>- Semantic HTML Use the <address> tag to semantically mark up the location of Jessica.
- SEO Optimization Add a meta description for search engines to better understand the content of your page:
These suggestions will help make your page more accessible, SEO-friendly, and performant! You are doing great. keep it up!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord