Submitted 3 months ago

social links profile

Shakil ahmed• 260

@Shakil-a

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Social links profile

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

im most proud of getting the style as close to the design and also working with the designing of the list items

What challenges did you encounter, and how did you overcome them?

styling the list items but i used w3schools as a reference on how to complete it

What specific areas of your project would you like help with?

just a general look to see if the html and css can be optimised to be better

Community feedback

Darkstar• 1,000

@DarkstarXDD

Posted 3 months ago

Don't limit the container height. Let the browser decide the containers height based on the elements inside it. Setting a fixed height prevents the container from scaling as needed, causing content to overflow.
Use max-width instead of width. That way the width is limited, but it can go narrower when it needs to like on smaller screens. Better if you set the max-width in rem.
The location is not a heading. It's a <p>.
Never set font-sizes in px. Always use rem for font-sizes. read
Every page needs a <main> landmark. read

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord