Social Links Profile

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @jamiuTheDev

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.

  • I suggest using clear descriptive CSS classes like .card, .card-title and .card-description.

  • Try using semantic HTML elements like main, section and article.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0

  ---

  

  jamiuTheDev•20

  @jamiuTheDevPosted 4 months ago

  Thank you for your advice. Would it be okay if I can contact you on my future challenges

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @jamiuTheDev

  Of course, I would appreciate it if you could mark my comment as helpful!

  Marked as helpful

  0
• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 4 months ago

  Hey there!

  Congrats on finishing the challenge! ✅

  Your solution looks awesome!

  📌 It's a good idea to use semantic HTML elements like <ul> and <li> for lists. This makes your code more accessible, maintainable, and meaningful.

  Here's an example of how you can refactor your code:

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  Using <ul> and <li> makes your content structure clearer, which is better for screen readers and search engines. Plus, it follows best practices for HTML.

  Hope this helps!

  Keep up the great work!

  0

  ---

  

  jamiuTheDev•20

  @jamiuTheDevPosted 4 months ago

  Thanks alot @danielmrz-dev

  0