Design comparison
Solution retrospective
Due to the presence of margins in the body, It was not possible to place it in the middle. I set the margin to 0!
What specific areas of your project would you like help with?Anything to make it better!
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ✅
Your solution looks great!
📌 It's recommended to use semantic HTML elements like
<ul>
and<li>
for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.Here's and example on how you can refactor your code:
After Refactoring
<ul class="list-container"> <li><a href="#">Github</a></li> <li><a href="#">Frontend Mentor</a></li> <li><a href="#">LinkedIn</a></li> ... </ul>
By using
<ul>
and<li>
, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.I hope you find this helpful!
Keep up the excellent work!
0@ima9ghPosted 5 months agoHi @danielmrz-dev
Thank you for your feedback.
I used ul and li first, but li took the left margin because I didn't know how to fix it, so I used div!
1@danielmrz-devPosted 5 months ago@ima9gh
You have to set
list-style-type: none
to the<li>
elements. They have padding left by default, but it's possible to remove it.Marked as helpful0@ima9ghPosted 5 months ago@danielmrz-dev
Why didn't the text turn black when I put <a> on the hover, What is the problem?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord