Social Links Profile

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 7 months ago

  Hello @jvisme1991!

  Your solution looks great!

  📌 Instead of using <div> as a container and <a> as list items, it's recommended to use semantic HTML elements like <ul> and <li> for creating lists. This ensures that your code is more accessible, maintainable, and semantically meaningful.

  Here's and example on how you can refactor your code:

  Before Refactoring

  <div class="list-container">
      <a href="#">Github</a>
      <a href="#">Frontend Mentor</a>
      <a href="#">LinkedIn</a>
      ...
  </div>
  

  After Refactoring

  <ul class="list-container">
      <li><a href="#">Github</a></li>
      <li><a href="#">Frontend Mentor</a></li>
      <li><a href="#">LinkedIn</a></li>
      ...
  </ul>
  

  By using <ul> and <li>, you convey the structure of your content more clearly, making it easier for screen readers and search engines to understand. Additionally, it aligns with best practices for HTML semantics.

  I hope you find this helpful!

  Keep up the excellent work!

  Marked as helpful

  0

  ---

  

  Jarrod Ver Hey•150

  @jvisme1991Posted 7 months ago

  I appreciate the feedback! I actually just used buttons instead of a list or anchors. I will keep this in mind though!! @danielmrz-dev

  0