@DylandeBruijn
Posted
@thanhsHai
Hiya! 👋
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve ✍️
-
You could add a
min-height: 100vh
to yourbody
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
-
I suggest using clear descriptive CSS classes like
.card
,.card-title
and.card-description
. -
Try using semantic HTML elements like
main
,section
andarticle
. -
By convention CSS classes should be formatted in all lowercase with dashes (-) between words. You would use camelcase in combination with Javascript.
-
Instead of a
background-image
for your profile image you could use a normal image and achieve the same effect. -
Try using relative CSS units like
rem
andem
. -
Try using
a
tags for you links and putting them in a list.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟
Let me know if you have more questions and I'll do my best to answer them. 🙋♂️
Happy coding! 😎
Marked as helpful