Social Links Profile

Community feedback

• 

  artemkotko14•100

  @artemkotko14Posted about 1 month ago

  Great job on this challange! A few things I would suggest to consider:

  1. Use <a> or <button> instead of <li>. Think of it as a real website, if a user clicks one of these buttons, it takes them to another page. With <li> you are not gonna have possibility to implement such functionality.
  2. Your buttons don't have a focus state, so I can't move through your page without a mouse.
  3. Add cursor: pointer; to your hover state, to make it look the same as at the design.
  4. Also you used px for your font-size which is not a good practise. You can read aboit it in this article: Article

  0
• 

  Md Zafer Eqbal•80

  @MdZaferEqbalPosted about 1 month ago

  Its nearly perfect apart from some padding and margin

  0