Social-Links-Profile

Community feedback

• 

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  Hello again, Good to see you engaging, here is some feedback on this project..

  • Your <div> text should be wrapped with a <a> so it is accessible with a keyboard using the tab key, Using an <a> tag for navigation is semantically correct, improves accessibility for screen readers, and ensures consistent behavior across browsers, unlike a <button> or a <div> not intended for links.

    <div class="social-buttons">
      <div class="button">GitHub</div>
      <div class="button">Frontend Mentor</div>
      <div class="button">LinkedIn</div>
      <div class="button">Twitter</div>
      <div class="button">Instagram</div>
  </div>
  

  • Big one for responsive web site is using relative units and developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  Keep building on your knowledge, and remember, every step forward is progress. You’re on the right track, and you’re doing great. Have an awesome day and happy coding! 😊

  Marked as helpful

  0
• 

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  @Omarbergaoui, I’d like to provide some feedback. In past challenges, I noticed you haven't engaged or responded when solutions were submitted. Networking and actively engaging with the community are essential, and I highly encourage you to embrace these practices. They can greatly enhance collaboration and growth.

  Marked as helpful

  0

  ---

  

  omar bergaoui•40

  @OmarbergaouiPosted about 2 months ago

  @Stroudy Thank you for your feedback. I truly appreciate you bringing this to my attention. I realize I haven’t engaged as much as I should have, and it wasn’t intentional. I just didn’t focus on it as much at the time, but I understand how important networking and active participation are for personal growth and collaboration. I will definitely work on improving in this area moving forward.

  1

  

  P

  Steven Stroud•11,870

  @StroudyPosted about 2 months ago

  @Omarbergaoui, It is good to see you here 😁, I am looking forward to seeing some more from you.

  1